On Thu, 14 Nov 2024 06:15:15 +0530 Manas via B4 Relay wrote:Hi Jakub, thanks for reviewing this.
- if (extack->bad_attr &&
+ if (extack->bad_attr && strlen(in_skb->data) &&
!WARN_ON((u8 *)extack->bad_attr < in_skb->data ||
(u8 *)extack->bad_attr >= in_skb->data + in_skb->len))
that's most definitely not the right fix.
in_skb->data points to binary data.
my best idea so far is to rework this check to use nlh, because in_skb
will be pulled at this stage for dumps
if that makes sense to you please give it a go, otherwise I'll work on
the fix tomorrow