Re: [PATCH can-next v4 2/2] can: tcan4x5x: add option for selecting nWKRQ voltage

From: Sean Nyekjaer
Date: Thu Nov 14 2024 - 04:27:11 EST


On Thu, Nov 14, 2024 at 10:19:00AM +0100, Marc Kleine-Budde wrote:
> On 14.11.2024 09:52:22, Sean Nyekjaer wrote:
> > The nWKRQ pin supports an output voltage of either the internal reference
> > voltage (3.6V) or the reference voltage of
> > the digital interface 0-6V (VIO).
> > Add the devicetree option ti,nwkrq-voltage-vio to set it to VIO.
> >
> > If this property is omitted the reset default, the internal reference
> > voltage, is used.
> >
> > Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> > Reviewed-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>
> I've given my R-b to 1/2 not 2/2 :)
>
> Have you manually added the R-b? "b4" has an support to collect the
> trailers and add the to the patches with "b4 trailers -u".
>
> With this change, let b4 add by R-b:
>
> Reviewed-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>
> regards,
> Marc
>

Oh, I see my bad :)

Actually just went thru the b4 manual and didn't see that option.

Ran the "b4 trailers -u", It added the Acked-by: in
https://lore.kernel.org/all/20241114-quirky-aquamarine-junglefowl-408784-mkl@xxxxxxxxxxxxxx/

Thanks.
/Sean