Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Switch to IMMEDIATE_MODE

[AngeloGioacchino Del Regno]

Il 14/11/24 09:13, Daniel Lezcano ha scritto:
> On 08/11/2024 07:46, Hsin-Te Yuan wrote:
> > Currently, MT8192 cannot suspend with FILTERED_MODE. Switch to
> > IMMEDIATE_MODE will fix this.
>
> Given the comments and the different changes related to the filtered and immediate 
> modes, I won't apply the patch until this is clearly sorted out.

Thanks - indeed do not apply this for now.

If this has been broken for a year, one or two more weeks ain't gonna be a
show stopper, as long as we can come to a proper fix during that time, instead
of yet another compromise.

Anyway....

We discussed about that internally and we do suspect that there might be some
interrupt that is getting erroneously enabled, never handled, and constantly
firing because.. well, it was never handled, so... :-)

Nicolas is looking into this issue, and I really hope that we can come to a
conclusion that will make us switch back all of the SoCs to filtered mode
instead, as there indeed are some advantages in using that.

Cheers,
Angelo

> > Signed-off-by: Hsin-Te Yuan <yuanhsinte@xxxxxxxxxxxx>
> > ---
> >   drivers/thermal/mediatek/lvts_thermal.c | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/ 
> > lvts_thermal.c
> > index 
> > 1997e91bb3be94a3059db619238aa5787edc7675..daad52f14fc03d0c4131f2ffdf3eb6b49a4a43d0 100644
> > --- a/drivers/thermal/mediatek/lvts_thermal.c
> > +++ b/drivers/thermal/mediatek/lvts_thermal.c
> > @@ -1541,7 +1541,6 @@ static const struct lvts_ctrl_data 
> > mt8192_lvts_mcu_data_ctrl[] = {
> >           },
> >           VALID_SENSOR_MAP(1, 1, 0, 0),
> >           .offset = 0x0,
> > -        .mode = LVTS_MSR_FILTERED_MODE,
> >       },
> >       {
> >           .lvts_sensor = {
> > @@ -1552,7 +1551,6 @@ static const struct lvts_ctrl_data 
> > mt8192_lvts_mcu_data_ctrl[] = {
> >           },
> >           VALID_SENSOR_MAP(1, 1, 0, 0),
> >           .offset = 0x100,
> > -        .mode = LVTS_MSR_FILTERED_MODE,
> >       },
> >       {
> >           .lvts_sensor = {
> > @@ -1567,7 +1565,6 @@ static const struct lvts_ctrl_data 
> > mt8192_lvts_mcu_data_ctrl[] = {
> >           },
> >           VALID_SENSOR_MAP(1, 1, 1, 1),
> >           .offset = 0x200,
> > -        .mode = LVTS_MSR_FILTERED_MODE,
> >       }
> >   };
> >
> > ---
> > base-commit: 906bd684e4b1e517dd424a354744c5b0aebef8af
> > change-id: 20241108-lvts-f7beb36efc59
> >
> > Best regards,