Re: [PATCH 2/2] kbuild: remove support for single %.symtypes build rule
From: Nicolas Schier
Date: Thu Nov 14 2024 - 05:57:31 EST
On Tue, Nov 12, 2024 at 02:17:41AM +0900, Masahiro Yamada wrote:
> This rule is unnecessary because you can generate foo/bar.symtypes
> as a side effect using:
>
> $ make KBUILD_SYMTYPES=1 foo/bar.o
>
> While compiling *.o is slower than preprocessing, the impact is
> negligible. I prioritize keeping the code simpler.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
>
> Makefile | 2 +-
> scripts/Makefile.build | 20 +++-----------------
> 2 files changed, 4 insertions(+), 18 deletions(-)
thanks, looks good to me.
Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>