Re: [PATCH v1 1/1] gpio: Move and sort Kconfig entries as suggested

[Bartosz Golaszewski]

On Thu, Nov 14, 2024 at 11:39 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Thu, Nov 14, 2024 at 09:54:50AM +0100, Bartosz Golaszewski wrote:
> > On Wed, Nov 13, 2024 at 6:12 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > >
> > > The Kconfig under drivers/gpio has a specific comment
> > >
> > >   put drivers in the right section, in alphabetical order
> > >
> > > but in time some of the entries fell unordered there.
> > > Put an order again.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > Could you elaborate on why you're moving drivers between categories?
> > For instance: you moved Intel LJCA to USB drivers and I'm sure you
> > have a reason for it (it's not clear if this actually is a USB driver,
>
> This one is actually clear as you see that it depends on USB_LJCS which
> suggests that it's USB based.
>
> > it's not registered as such
>
> Neither one of the existing ones in that category, right?
>

Well if you really want to open that can of worms...

Only gpio-mpsse is really a stand-alone USB GPIO expander. Others in
this section are actually MFD devices and would probably better fit in
there.

I don't have a strong opinion but we should at least be consistent.

Bart

> > ) but please expand on it in the commit message.
>
> Okay, I will do in v2.
>
> Thank you for the review!
>
> --
> With Best Regards,
> Andy Shevchenko
>
>