Re: [PATCH] net: wwan: Add WWAN sahara port type

From: Sergey Ryazanov
Date: Thu Nov 14 2024 - 15:16:25 EST


Hello Jerry,

On 14.11.2024 10:45, Jerry Meng(蒙杰) wrote:
Add a Sahara protocol-based interface for downloading ramdump
from Qualcomm modems in SBL ramdump mode.

Signed-off-by: Jerry Meng <jerry.meng@xxxxxxxxxxx>
---
drivers/net/wwan/mhi_wwan_ctrl.c | 3 ++-
drivers/net/wwan/wwan_core.c | 4 ++++
include/linux/wwan.h | 2 ++
3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c
index e9f979d2d..2c6a754af 100644
--- a/drivers/net/wwan/mhi_wwan_ctrl.c
+++ b/drivers/net/wwan/mhi_wwan_ctrl.c
@@ -263,7 +263,8 @@ static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = {
{ .chan = "QMI", .driver_data = WWAN_PORT_QMI },
{ .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
{ .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE },
- {},
+ { .chan = "SAHARA", .driver_data = WWAN_PORT_SAHARA},
^
White space is missed between the port type and '}' -'

Please run the checkpatch.pl before submission, and use git-send-email(1) when it is possible.


$ ./scripts/checkpatch.pl net-wwan-Add-WWAN-sahara-port-type.patch
...
total: 6 errors, 6 warnings, 33 lines check

--
Sergey