Re: [PATCH net v1 2/2] net: stmmac: set initial EEE policy configuration

[Choong Yong Liang]

On 14/11/2024 10:19 pm, Andrew Lunn wrote:
> On Thu, Nov 14, 2024 at 04:16:53PM +0800, Choong Yong Liang wrote:
> > Set the initial eee_cfg values to have 'ethtool --show-eee ' display
> > the initial EEE configuration.
> >
> > Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Choong Yong Liang <yong.liang.choong@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > index 7bf275f127c9..5fce52a9412e 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > @@ -1204,7 +1204,7 @@ static int stmmac_init_phy(struct net_device *dev)
> >   			netdev_err(priv->dev, "no phy at addr %d\n", addr);
> >   			return -ENODEV;
> >   		}
> > -
> > +		phy_support_eee(phydev);
> >   		ret = phylink_connect_phy(priv->phylink, phydev);
>
> Is supporting EEE a synthesis option, or is it always available?
>
> Some EEE code is guarded by:
>
>          if (!priv->dma_cap.eee)
>                  return -EOPNOTSUPP;
>
> 	Andrew

It's a synthesis option that should check priv->dma_cap.eee before setting 
EEE. I will update it in the next version.