Re: [PATCH net-next v0 1/1] net: mv643xx_eth: disable IP tx checksum with jumbo frames for Armada 310

From: Jakub Kicinski
Date: Thu Nov 14 2024 - 22:25:12 EST


On Wed, 13 Nov 2024 21:00:40 +1000 Qingtao Cao wrote:
> The Ethernet controller found in Armada 310 doesn't support TCP/IP checksum
> with frame sizes larger than its TX checksum offload limit
>
> Disable the features NETIF_F_IP_CSUM and NETIF_F_TSO when the MTU is set to
> a value larger than this limit, to prevent the software TSO generating GSO
> packets that are not suitable to offload to the Ethernet controller, which
> would be calculated by the IP stack instead.

Did you consider disabling it per packet using .ndo_features_check ?