Re: [PATCH 4/5] arm64: dts: qcom: qcs8300: enable pcie0 for QCS8300

[Tingwei Zhang]

On 11/14/2024 9:03 PM, Konrad Dybcio wrote:
> On 14.11.2024 1:10 PM, Dmitry Baryshkov wrote:
> > On Thu, Nov 14, 2024 at 05:54:08PM +0800, Ziyue Zhang wrote:
> > > Add configurations in devicetree for PCIe0, including registers, clocks,
> > > interrupts and phy setting sequence.
> > >
> > > Signed-off-by: Ziyue Zhang <quic_ziyuzhan@xxxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcs8300-ride.dts |  44 +++++-
> > >   arch/arm64/boot/dts/qcom/qcs8300.dtsi     | 176 ++++++++++++++++++++++
> > >   2 files changed, 219 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > > index 7eed19a694c3..9d7c8555ed38 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > > +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > > @@ -213,7 +213,7 @@ vreg_l9c: ldo9 {
> > >   &gcc {
> >
> > The patch doesn't seem to update the gcc node in qcs8300.dtsi. Is there
> > any reason to have the clocks property in the board data file?
>
> Definitely not. Ziyue, please move that change to the soc dtsi

Gcc node is updated in board device tree due to sleep_clk is defined in 
board device tree. Sleep_clk is from PMIC instead SoC so we were 
requested to move sleep_clk to board device tree in previous review [1].

[1]https://lore.kernel.org/all/10914199-1e86-4a2e-aec8-2a48cc49ef14@xxxxxxxxxx/
> Konrad


--
Thanks,
Tingwei