Re: [PATCH] dt-bindings: PCI: snps,dw-pcie: Drop "#interrupt-cells" from example

[Manivannan Sadhasivam]

On Tue, Nov 05, 2024 at 03:32:16PM -0600, Rob Herring (Arm) wrote:
> "#interrupt-cells" is not valid without a corresponding "interrupt-map"
> or "interrupt-controller" property. As the example has neither, drop
> "#interrupt-cells". This fixes a dtc interrupt_provider warning.
> 

But the DWC controllers have an in-built MSI controller. Shouldn't we add
'interrrupt-controller' property then?

- Mani

> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> index 548f59d76ef2..205326fb2d75 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> @@ -230,7 +230,6 @@ examples:
>  
>        interrupts = <25>, <24>;
>        interrupt-names = "msi", "hp";
> -      #interrupt-cells = <1>;
>  
>        reset-gpios = <&port0 0 1>;
>  
> -- 
> 2.45.2
> 

-- 
மணிவண்ணன் சதாசிவம்