Re: [PATCH net-next v19 03/10] ptp: Add phc source and helpers to register specific PTP clock or get information

From: Kory Maincent
Date: Fri Nov 15 2024 - 04:13:15 EST


On Thu, 14 Nov 2024 17:39:06 -0800
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> On Thu, 14 Nov 2024 11:46:10 +0100 Kory Maincent wrote:
> [...]
> > >
> > > In net_device? Yes, I think so.
> >
> > Also as the "user" is not described in the ptp_clock structure the only way
> > to find it is to roll through all the PTP of the concerned net device
> > topology. This find ptp loop will not be in the hotpath but only when
> > getting the tsinfo of a PHC or changing the current PHC. Is it ok for you?
>
> I think so :) We need to be able to figure out if it's the MAC PHC
> quickly, because MAC timestamping can be high rate. But IIUC PHY
> timestamping will usually involve async work and slow buses, so
> walking all PHYs of a netdev should be fine. Especially that 99%
> of the time there will only be one. Hope I understood the question..

Yes, thanks for the confirmation.

Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com