Re: Of fsl_mc_allocator_driver_exit

[Ioana Ciornei]

On Fri, Nov 15, 2024 at 02:26:19PM +0000, Dr. David Alan Gilbert wrote:
> * Ioana Ciornei (ioana.ciornei@xxxxxxx) wrote:
> > > * Dr. David Alan Gilbert (linux@xxxxxxxxxxx) wrote:
> > > > Hi,
> > > >   One of my scripts noticed that fsl_mc_allocator_driver_exit()
> > > > was added explicitly in
> > > > commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")
> > > >
> > > > but appears to be unused; given it's a cleanup function it feels like
> > > > it should be wired up _somewhere_.
> > > >
> >
> > I don't think that fsl_mc_allocator_driver_exit() is of any use at this
> > point. The entire FSL_MC_BUS can only be built-in which means that there
> > is no module_exit() which references it.
>
> OK, well I'm happy to send a patch to clean it out, I was also
> going to clean out fsl_mc_portal_reset().

Sure. Please keep me in cc so that I can give it a run.

>
> > The same thing is true about the dprc_driver_exit() function.
>
> Hmm, that's explicitly called from the error path of fsl_mc_bus_driver_init

My bad. I missed that.

Thanks,
Ioana