Re: [PATCH liburing] test: add test cases for hybrid iopoll
From: Jens Axboe
Date: Fri Nov 15 2024 - 10:47:23 EST
On 11/14/24 8:34 PM, hexue wrote:
>> The kernel should already do this, no point duplicating it in liburing.
>>
>> The test bits look much better now, way simpler. I'll just need to
>> double check that they handle EINVAL on setup properly, and EOPNOTSUPP
>> at completion time will turn off further testing of it. Did you run it
>> on configurations where hybrid io polling will both fail at setup time,
>> and at runtime (eg the latter where the kernel supports it, but the
>> device/fs does not)?
>
> Yes, I have run both of these error configurations. The running cases are:
> hybrid poll without IORING_SETUP_IOPOLL and device with incorrect queue
> configuration, EINVAL and EOPNOTSUPP are both identified.
I figured that was the case, as the existing test case should already
cover both of those cases. I'll get this applied once you send the
updated version.
--
Jens Axboe