Re: [PATCH] hfs: Fix uninitialized value issue in hfs_iget

From: Suraj Sonawane
Date: Fri Nov 15 2024 - 10:53:33 EST


On 23/09/24 23:30, SurajSonawane2415 wrote:
Fix uninitialized value issue in hfs_iget by initializing the hfs_cat_rec
structure in hfs_lookup.

Reported-by: syzbot+18dd03a3fcf0ffe27da0@xxxxxxxxxxxxxxxxxxxxxxxxx
Closes: https://syzkaller.appspot.com/bug?extid=18dd03a3fcf0ffe27da0
Tested-by: syzbot+18dd03a3fcf0ffe27da0@xxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: SurajSonawane2415 <surajsonawane0215@xxxxxxxxx>
---
fs/hfs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/hfs/dir.c b/fs/hfs/dir.c
index b75c26045df4..3b880b3e4b4c 100644
--- a/fs/hfs/dir.c
+++ b/fs/hfs/dir.c
@@ -20,7 +20,7 @@
static struct dentry *hfs_lookup(struct inode *dir, struct dentry *dentry,
unsigned int flags)
{
- hfs_cat_rec rec;
+ hfs_cat_rec rec = {0};
struct hfs_find_data fd;
struct inode *inode = NULL;
int res;

I wanted to follow up on the patch I submitted. I was wondering if you had a chance to review it and if there are any comments or feedback.

Thank you for your time and consideration. I look forward to your response.

Best regards,
Suraj Sonawane