Re: [PATCH v2 2/2] hwmon: (core) Avoid ifdef CONFIG_THERMAL in C source file

From: Guenter Roeck
Date: Fri Nov 15 2024 - 12:13:24 EST


On 11/15/24 08:40, Thomas Weißschuh wrote:
Using an #ifdef in a C source files to have different definitions
of the same symbol makes the code harder to read and understand.
Furthermore it makes it harder to test compilation of the different
branches.

Replace the ifdeffery with IS_ENABLED() which is just a normal
conditional.
The resulting binary is still the same as before as the compiler
optimizes away all the unused code and definitions.

Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

For my reference:

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Pending acceptance of the first patch in the series.

Thanks,
Guenter