Re: [PATCH v2] efi: Fix memory leak in efivar_ssdt_load

[Cyrill Gorcunov]

On Fri, Nov 15, 2024 at 06:02:07PM +0100, Ard Biesheuvel wrote:
> > It is still unclear for me why we don't exit with error if acpi_load_table
> > failed but continue to iterate keys and don't report a caller with error
> > instead. I didn't change this logic for backward compatibility sake but
> > still looks suspicious.
> >
> 
> I've queued this up now.
> 
> I think there may be cases where it might make sense, or at least,
> where currently, we might rely on the behavior where acpi_load_table()
> failures are ignored. If a table references an object that does not
> exist in the namespace (e.g., because some I2C controller is
> disabled), it might still make sense to load remaining SSDTs if they
> describe things that are unrelated.

Yeah, sound reasonable. Thanks, Ard!