Re: [PATCH linux-next] lib/string_choices: Add str_locked_unlocked()/str_unlocked_locked() helper
From: Andy Shevchenko
Date: Fri Nov 15 2024 - 14:47:27 EST
On Fri, Nov 15, 2024 at 9:44 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Nov 15, 2024 at 4:47 PM R Sundar <prosunofficial@xxxxxxxxx> wrote:
...
> > --- a/include/linux/string_choices.h
> > +++ b/include/linux/string_choices.h
> > @@ -82,4 +82,10 @@ static inline const char *str_plural(size_t num)
> > return num == 1 ? "" : "s";
> > }
> >
> > +static inline const char *str_locked_unlocked(bool v)
> > +{
> > + return v ? "locked" : "unlocked";
> > +}
> > +#define str_unlocked_locked(v) str_locked_unlocked(!(v))
>
> The rest is sorted (okay, read_write() seems to be misplaced, fix that
> in a separate change if you wish), please keep it that way (I believe
> it should go before on_off).
Oh, I looked in v6.11 code, in v6.12 there are a couple of more
misplacements. Can you fix them all, please?
--
With Best Regards,
Andy Shevchenko