Re: [PATCH] arch:x86:coco:sev: Initialize ctxt variable

From: Ragavendra B.N.
Date: Fri Nov 15 2024 - 16:02:44 EST


On Fri, Nov 15, 2024 at 01:20:15PM -0600, Tom Lendacky wrote:
> On 11/15/24 12:37, Ragavendra B.N. wrote:
> > On Fri, Nov 15, 2024 at 12:01:03PM +0100, Ingo Molnar wrote:
> >>
> >> * Ragavendra <ragavendra.bn@xxxxxxxxx> wrote:
> >>
> >>> Updating the ctxt value to NULL in the svsm_perform_ghcb_protocol as
> >>> it was not initialized.
> >>>
> >>> Fixes: 2e1b3cc9d7f7 (grafted) Merge tag 'arm-fixes-6.12-2' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
> >>
> >> This 'Fixes' tag looks bogus.
> >>
> >> Thanks,
> >>
> >> Ingo
> > Please feel free to suggest the valid tag as the file was renamed and I am not able to fetch the correct commit id.
> > git log --oneline arch/x86/coco/sev/shared.c
> > f50cd034d24d (HEAD -> 1594023) arch:x86:coco:sev: Initialize ctxt variable
> > 2e1b3cc9d7f7 (grafted) Merge tag 'arm-fixes-6.12-2' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
>
> A quick git annotate arch/x86/coco/sev/shared.c shows that function was
> created with:
>
> 34ff65901735 ("x86/sev: Use kernel provided SVSM Calling Areas")
>
> Thanks,
> Tom
>
> >
> > --
> > Thanks,
> > Ragavendra
Thanks a lot Tom.

I figured why I ran into it in the first place. When I cloned, I cloned with --depth 1 as I had less free space in that partition. The annotate flag certainly helped to retrieve the exact commit id.

--
Regards,
Ragavendra N
,