Re: [PATCH net-next v2 7/8] ethtool: remove the comments that are not gonna be generated
From: Jakub Kicinski
Date: Fri Nov 15 2024 - 17:08:04 EST
On Fri, 15 Nov 2024 11:36:45 -0800 Stanislav Fomichev wrote:
> -/* MAC Merge (802.3) */
> -
> enum {
> ETHTOOL_A_MM_STAT_UNSPEC,
> ETHTOOL_A_MM_STAT_PAD,
> + ETHTOOL_A_MM_STAT_REASSEMBLY_ERRORS,
> + ETHTOOL_A_MM_STAT_SMD_ERRORS,
> + ETHTOOL_A_MM_STAT_REASSEMBLY_OK,
> + ETHTOOL_A_MM_STAT_RX_FRAG_COUNT,
> + ETHTOOL_A_MM_STAT_TX_FRAG_COUNT,
> + ETHTOOL_A_MM_STAT_HOLD_COUNT,
>
> - /* aMACMergeFrameAssErrorCount */
> - ETHTOOL_A_MM_STAT_REASSEMBLY_ERRORS, /* u64 */
> - /* aMACMergeFrameSmdErrorCount */
> - ETHTOOL_A_MM_STAT_SMD_ERRORS, /* u64 */
> - /* aMACMergeFrameAssOkCount */
> - ETHTOOL_A_MM_STAT_REASSEMBLY_OK, /* u64 */
> - /* aMACMergeFragCountRx */
> - ETHTOOL_A_MM_STAT_RX_FRAG_COUNT, /* u64 */
> - /* aMACMergeFragCountTx */
> - ETHTOOL_A_MM_STAT_TX_FRAG_COUNT, /* u64 */
> - /* aMACMergeHoldCount */
> - ETHTOOL_A_MM_STAT_HOLD_COUNT, /* u64 */
These comments could be useful to cross reference with the IEEE spec.
Can we add them as doc: ?