Re: [PATCH] ACPI: Remove msleep() bloat from acpi_os_sleep()
From: Rafael J. Wysocki
Date: Fri Nov 15 2024 - 17:10:40 EST
On Fri, Nov 15, 2024 at 10:20 PM Len Brown <lenb@xxxxxxxxxx> wrote:
>
> Re: if short sleep then use usleep_range()
>
> I think we all agree on this.
>
> Though in the ACPI flows that brought up this topic, setting max to
> anything other than min is simply a request for bad performance.
I disagree with the "bad performance" statement.
Performance lower than the possible maximum doesn't necessarily count as "bad".
> Re: if long sleeps then use msleep()
>
> ... because a jiffy based timer effectively forces coalescing, and is
> the lowest overhead.
>
> The problem with this logic is, as you mention, coalescing is a
> function of the distribution of timer expirations over time,it is not
> a function of the duration of those timers.
I just think that high precision is not necessary for long timeouts.
I also don't think that ASL programmers expect high precision in those cases.