Re: [PATCH net-next v4] net: dlink: add support for reporting stats via `ethtool -S`
From: Jakub Kicinski
Date: Fri Nov 15 2024 - 19:49:02 EST
On Fri, 15 Nov 2024 00:19:48 +0900 Moon Yeounsu wrote:
> - dev->stats.rx_packets += dr32(FramesRcvOk);
> - dev->stats.tx_packets += dr32(FramesXmtOk);
> - dev->stats.rx_bytes += dr32(OctetRcvOk);
> - dev->stats.tx_bytes += dr32(OctetXmtOk);
> -
> - dev->stats.multicast = dr32(McstFramesRcvdOk);
> - dev->stats.collisions += dr32(SingleColFrames)
> - + dr32(MultiColFrames);
> -
> - /* detailed tx errors */
> - stat_reg = dr16(FramesAbortXSColls);
> - dev->stats.tx_aborted_errors += stat_reg;
> - dev->stats.tx_errors += stat_reg;
> -
> - stat_reg = dr16(CarrierSenseErrors);
> - dev->stats.tx_carrier_errors += stat_reg;
> - dev->stats.tx_errors += stat_reg;
Maybe I'm lost in the macros again, but I dont see where you are
updating dev->stats now.
Do basic stats still work?
ip -s -s link show
--
pw-bot: cr