Re: [PATCH 2/3] x86/ioremap: use helper to implement xxx_is_setup_data()
From: Ingo Molnar
Date: Sat Nov 16 2024 - 03:36:37 EST
* Tom Lendacky <thomas.lendacky@xxxxxxx> wrote:
> On 11/14/24 19:21, Baoquan He wrote:
> > This simplifies codes a lot by removing the duplicated code handling.
>
> You should probably squash this with the first patch.
>
> >
> > And also remove the similar code comment above of them.
> >
> > While at it, add __ref to memremap_is_setup_data() to avoid
>
> The __ref shouldn't be needed if you remove the __init from the helper
> function.
Yeah.
Baoquan, I've zapped these 3 commits from tip:x86/mm for now, mind resending them the init
annotations fixed?
Thanks,
Ingo