RE: [EXTERNAL] Re: [PATCH net v4 1/7] octeon_ep: Add checks to fix double free crashes

[Shinas Rasheed]

Hi Vadim,

> On 13/11/2024 11:13, Shinas Rasheed wrote:
> > From: Vimlesh Kumar <vimleshk@xxxxxxxxxxx>
> >
> > Add required checks to avoid double free. Crashes were
> > observed due to the same on reset scenarios, when reset
> > was tried multiple times, and the first reset had torn
> > down resources already.
> 
> I'm looking at the whole series and it feels like we have to deal
> with the root cause rather than add protective code left and right.
> 
> The driver may potentially have some locks missing which will cause
> missing resources, and to fix the root cause these locks have to be
> added. WDYT?

I will rework this patch series. I think some of the patchsets need not be present upstream
as they have come from some customer crashes which only occur in conjunction with other
proprietary modules and features present. I will rework this one to only include changes pertinent
to code upstream.

Thanks a lot for your comments