Re: [PATCH] ata: Constify struct pci_device_id

[Sergey Shtylyov]

On 11/16/24 12:08 AM, Christophe JAILLET wrote:

> 'struct pci_device_id' is not modified in these drivers.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>    4245	   1454	      4	   5703	   1647	drivers/ata/ata_generic.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>    4725	    974	      4	   5703	   1647	drivers/ata/ata_generic.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

[...]
   No longer an "official" PATA reviewer, but FWIW:

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

MBR, Sergey