[PATCH] vfs: move getattr in inode_operations to a more commonly read area

From: Mateusz Guzik
Date: Sun Nov 17 2024 - 19:20:47 EST


Notabaly occupied by lookup, get_link and permission.

This pushes unlink to another cache line, otherwise the layout is the
same on that front.

Signed-off-by: Mateusz Guzik <mjguzik@xxxxxxxxx>
---

Probably more can be done to rearrange struct. If someone is down to do
it, I'm happy with this patch being dropped.

include/linux/fs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 7e29433c5ecc..972147da71f9 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2140,6 +2140,8 @@ struct inode_operations {
const char * (*get_link) (struct dentry *, struct inode *, struct delayed_call *);
int (*permission) (struct mnt_idmap *, struct inode *, int);
struct posix_acl * (*get_inode_acl)(struct inode *, int, bool);
+ int (*getattr) (struct mnt_idmap *, const struct path *,
+ struct kstat *, u32, unsigned int);

int (*readlink) (struct dentry *, char __user *,int);

@@ -2157,8 +2159,6 @@ struct inode_operations {
int (*rename) (struct mnt_idmap *, struct inode *, struct dentry *,
struct inode *, struct dentry *, unsigned int);
int (*setattr) (struct mnt_idmap *, struct dentry *, struct iattr *);
- int (*getattr) (struct mnt_idmap *, const struct path *,
- struct kstat *, u32, unsigned int);
ssize_t (*listxattr) (struct dentry *, char *, size_t);
int (*fiemap)(struct inode *, struct fiemap_extent_info *, u64 start,
u64 len);
--
2.43.0