Re: [PATCH v3 6/6] arm64: dts: qcom: Add USB controller and phy nodes for IPQ5424

[Varadarajan Narayanan]

On Fri, Nov 15, 2024 at 08:54:47AM +0200, Dmitry Baryshkov wrote:
> On Fri, Nov 15, 2024 at 10:46:10AM +0530, Varadarajan Narayanan wrote:
> > On Thu, Nov 14, 2024 at 03:28:36PM +0200, Dmitry Baryshkov wrote:
> > > On Thu, 14 Nov 2024 at 09:48, Varadarajan Narayanan
> > > <quic_varada@xxxxxxxxxxx> wrote:
> > > >
> > > > The IPQ5424 SoC has both USB2.0 and USB3.0 controllers. The USB3.0
> > > > can connect to either of USB2.0 or USB3.0 phy and operate in the
> > > > respective mode.
> > > >
> > > > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> > > > ---
> > > > v3: Regulator node names, labels and 'regulator-name' changed per review suggestions
> > > >     Stray newline removed
> > > >
> > > > v2: Add dm/dp_hs_phy_irq to usb3@8a00000 node
> > > >     Add u1/u2-entry quirks to usb@8a00000 node
> > > > ---
> > > >  arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts |  66 ++++++++
> > > >  arch/arm64/boot/dts/qcom/ipq5424.dtsi       | 159 ++++++++++++++++++++
> > > >  2 files changed, 225 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > > > index d4d31026a026..859e15befb3f 100644
> > > > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > > > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > > > @@ -16,12 +16,70 @@ / {
> > > >         aliases {
> > > >                 serial0 = &uart1;
> > > >         };
> > > > +
> > > > +       vreg_misc_3p3: regulator-3300000 {
> > >
> > > Technically these names are correct. However they don't match the
> > > approach that Qualcomm DT files have been using up to now.
> > > You can compare your data with the output of `git grep :.regulator-
> > > arch/arm64/boot/dts/qcom/`
> >
> > Dmitry,
> >
> > This name was suggested by Rob Herring [1]. Shall I rename them as follows
> >
> > 	regulator-usb-3p3
> > 	regulator-usb-1p8
> > 	regulator-usb-0p925
>
> I'd say so. Rob clearly stated that this is not a strict rule. It's
> always better to follow the customs of the particular platform, it helps
> other developers. Also in _many_ cases just defining the voltage is not
> enough, usually there are multiple networks providing 0.925 V or 1.8 V.

Dmitry,

Have posted v4 with above changes. Please review.

Thanks
Varada

> > 1 - https://lore.kernel.org/linux-arm-msm/20241113181138.GA1011553-robh@xxxxxxxxxx/
> >
> > > > +               compatible = "regulator-fixed";
> > > > +               regulator-min-microvolt = <3300000>;
> > > > +               regulator-max-microvolt = <3300000>;
> > > > +               regulator-boot-on;
> > > > +               regulator-always-on;
> > > > +               regulator-name = "usb_hs_vdda_3p3";
> > > > +       };
> > > > +
> > > > +       vreg_misc_1p8: regulator-1800000 {
> > > > +               compatible = "regulator-fixed";
> > > > +               regulator-min-microvolt = <1800000>;
> > > > +               regulator-max-microvolt = <1800000>;
> > > > +               regulator-boot-on;
> > > > +               regulator-always-on;
> > > > +               regulator-name = "vdda_1p8_usb";
> > > > +       };
> > > > +
> > > > +       vreg_misc_0p925: regulator-0925000 {
> > > > +               compatible = "regulator-fixed";
> > > > +               regulator-min-microvolt = <925000>;
> > > > +               regulator-max-microvolt = <925000>;
> > > > +               regulator-boot-on;
> > > > +               regulator-always-on;
> > > > +               regulator-name = "vdd_core_usb";
> > > > +       };
> > > > +};
> >
> > [. . .]
>
> --
> With best wishes
> Dmitry