回覆: [net-next v2 5/7] net: ftgmac100: add pin strap configuration for AST2700
From: Jacky Chou
Date: Mon Nov 18 2024 - 02:51:25 EST
Hi Arnd,
Thank you for your reply.
> > @@ -351,6 +352,10 @@ static void ftgmac100_start_hw(struct ftgmac100
> *priv)
> > if (priv->netdev->features & NETIF_F_HW_VLAN_CTAG_RX)
> > maccr |= FTGMAC100_MACCR_RM_VLAN;
> >
> > + if (of_device_is_compatible(priv->dev->of_node,
> > +"aspeed,ast2700-mac")
> > &&
> > + phydev && phydev->interface == PHY_INTERFACE_MODE_RMII)
> > + maccr |= FTGMAC100_MACCR_RMII_ENABLE;
> > +
> > /* Hit the HW */
>
> Is there a way to probe the presence of 64-bit addressing from hardware
> registers? That would be nicer than triggering it from the compatible string,
> given that any future SoC is likely also 64-bit.
There is no register indicated about 64-bit address support in the ftgmac100
of Aspeed 7th generation. Therefore, we use the compatible to configure pin strap
and DMA mask.
Thanks,
Jacky