Re: [PATCH v1 03/10] media: platform: mediatek: add isp_7x seninf unit

[CK Hu (胡俊光)]

Hi, Shu-hsiang:

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces the driver of the MediaTek Sensor Interface,
> focusing on integration with the MediaTek ISP CAMSYS. The
> seninf device bridges camera sensors and the ISP system,
> providing management for sensor data routing and processing.
> Key features include V4L2 framework control, and dynamic
> handling of stream configurations and virtual channels.
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---

[snip]

> +struct seninf_vc {
> +	u8 vc;

vc is always zero, so drop it.

Regards,
CK

> +	u8 dt;
> +	u8 feature;
> +	u8 out_pad;
> +	u8 pixel_mode;
> +	u8 group;
> +	u8 mux; /* allocated per group */
> +	u8 cam; /* assigned by cam driver */
> +	u8 enable;
> +	u16 exp_hsize;
> +	u16 exp_vsize;
> +};
> +