Re: [RFC PATCH v2 1/3] x86: cpu/bugs: update SpectreRSB comments for AMD
From: Shah, Amit
Date: Mon Nov 18 2024 - 05:20:54 EST
On Fri, 2024-11-15 at 10:10 -0800, Josh Poimboeuf wrote:
> On Fri, Nov 15, 2024 at 09:50:47AM -0800, Pawan Gupta wrote:
> > This LGTM.
> >
> > I think SPECTRE_V2_EIBRS_RETPOLINE is placed in the wrong leg, it
> > doesn't need RSB filling on context switch, and only needs
> > VMEXIT_LITE.
> > Does below change on top of your patch look okay?
>
> Yeah, I was wondering about that too. Since it changes existing
> VMEXIT_LITE behavior I'll make it a separate patch. And I'll
> probably
> do the comment changes in a separate patch as well.
So all of that looks good to me as well. I think a standalone series
makes sense - maybe even for 6.13. I'll base my patches on top of
yours.
Thanks!
Amit