Re: [External] Re: [PATCH] fuse: check attributes staleness on fuse_iget()

From: Miklos Szeredi
Date: Mon Nov 18 2024 - 06:27:39 EST


On Mon, 18 Nov 2024 at 11:15, Zhang Tianci
<zhangtianci.1997@xxxxxxxxxxxxx> wrote:

> > + if (!evict_ctr || fi->attr_version || evict_ctr == fuse_get_evict_ctr(fc))
> > + set_mask_bits(&fi->inval_mask, STATX_BASIC_STATS, 0);
>
> This check should be moved to before the initialization of fi->attr_version.

Well spotted.

> > inode->i_ino = fuse_squash_ino(attr->ino);
> > inode->i_mode = (inode->i_mode & S_IFMT) | (attr->mode & 07777);
>
> And I will send out the v2 patch later.

Thanks, applied and pushed.

Miklos