Re: [PATCH net-next] intel/fm10k: Remove unused fm10k_iov_msg_mac_vlan_pf

[Dr. David Alan Gilbert]

* Przemek Kitszel (przemyslaw.kitszel@xxxxxxxxx) wrote:
> On 11/16/24 16:24, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > 
> > fm10k_iov_msg_mac_vlan_pf() has been unused since 2017's
> > commit 1f5c27e52857 ("fm10k: use the MAC/VLAN queue for VF<->PF MAC/VLAN
> > requests")
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> 
> makes sense, and all constants in the removed code seem to be used
> elsewhere, so:
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>

Thanks

> for you future Intel-Ethernet-only changes it would be better to
> target as [iwl-next] or [iwl-net],
> no need to repost just fro that

Ah OK; so are you going to pick this one up via iwl?

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/