Re: [PATCH net-next] net: phy: qt2025: simplify Result<()> in probe return

From: Shuah Khan
Date: Mon Nov 18 2024 - 16:23:27 EST


On 11/18/24 07:28, Manas wrote:
On 18.11.2024 15:15, Andrew Lunn wrote:
On Mon, Nov 18, 2024 at 06:39:34PM +0530, Manas via B4 Relay wrote:
From: Manas <manas18244@xxxxxxxxxxx>

probe returns a `Result<()>` type, which can be simplified as `Result`,
due to default type parameters being unit `()` and `Error` types. This
maintains a consistent usage of `Result` throughout codebase.

Signed-off-by: Manas <manas18244@xxxxxxxxxxx>

Miguel has already pointed out, this is probably not sufficient for a
signed-off-by: You need a real name here, in order to keep the lawyers happy.

Hi Andrew, I did clarify that "Manas" is my real name, (as in what the official
documents have). It is not a pseudonym. I am unsure if I am missing something
here.


Using your full name in your Signed-off-by clearly identifies the author.
I would recommend going that route.

thanks,
-- Shuah