Re: [PATCH v9 01/26] x86/resctrl: Add __init attribute for the functions called in resctrl_late_init

[Reinette Chatre]

Hi Babu,

On 11/18/24 9:44 AM, Moger, Babu wrote:
> Hi Reinette,
> 
> On 11/15/24 17:21, Reinette Chatre wrote:
>> Hi Babu,
>>
>> In subject please use () to indicate a function, writing resctrl_late_init()
> 
> Will change it to
> 
> x86/resctrl: Add __init attribute for all the call sequences in
> resctrl_late_init()

I am not sure how to interpret "call sequences". The original is ok now that
cache_alloc_hsw_probe() is also included. Specifically, this can be:

	x86/resctrl: Add __init attribute to functions called from resctrl_late_init()

> 
>>
>> On 10/29/24 4:21 PM, Babu Moger wrote:
>>> The function resctrl_late_init() has the __init attribute, but some
>>
>> No need to say "The function" when using ().
>>
>>> functions it calls do not. Add the __init attribute to all the functions
>>
>> None of the functions changed are actually called by resctrl_late_init(). If this
>> is indeed the goal then I think cache_alloc_hsw_probe() was missed.
> 
> Will change the function to.
> 
> static inline __init void cache_alloc_hsw_probe(void)
> 
> How about this description?
> 
> "resctrl_late_init() has the __init attribute, but some of the call
> sequences of it do not have the __init attribute.

"some of the call sequences of it" sounds strange. It can be simplified with
"some of the functions called from it"?

> 
> Add the __init attribute to all the functions in the call sequences to
> maintain consistency throughout."

Sounds good, thank you.

Reinette