Re: [PATCH net-next v1 1/1] net: mv643xx_eth: disable IP tx checksum with jumbo frames for Armada 310

[Jakub Kicinski]

On Mon, 18 Nov 2024 10:45:09 +1000 Qingtao Cao wrote:
> The Ethernet controller found in Armada 310 doesn't support TCP/IP checksum
> with frame sizes larger than its TX checksum offload limit
> 
> When the path MTU is larger than this limit, the skb_warn_bad_offload will
> throw out a warning oops
> 
> Disable the TX checksum offload (NETIF_F_IP_CSUM) when the MTU is set to a
> value larger than this limit, the NETIF_F_TSO will automatically be disabled
> as a result and the IP stack will calculate jumbo frames' checksum instead.

I thought I suggested ndo_features_check, why are you using
fix_features?
-- 
pw-bot: cr