回覆: [net-next 3/3] net: mdio: aspeed: Add dummy read for fire control

[Jacky Chou]

Hi Andrew Lunn,

Thank you for your reply.

> > >         iowrite32(ctrl, ctx->base + ASPEED_MDIO_CTRL);
> > > +       /* Add dummy read to ensure triggering mdio controller */
> > > +       (void)ioread32(ctx->base + ASPEED_MDIO_CTRL);
> >
> > Why do this when the same register is immediately read by
> > readl_poll_timeout() below?
> >
> > If there is a reason, I'd like some more explanation in the comment
> > you've added, discussing the details of the problem it's solving when
> > taking into account the readl_poll_timeout() call.
> 
> Also, is this a fix? Should it have a Fixes: tag? If so, it should not be part of this
> series, assuming the older devices have the same issue.

Agree.
It may be a fix. The patch is also applied in older device.
I will separate from this series and send it to net tree.

Thanks,
Jacky