RE: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS PHY bindings
From: 나소원/SOWON NA
Date: Tue Nov 19 2024 - 01:36:34 EST
Hi Alim,
On 11/19/24 2:21 PM, Alim Akhtar wrote:
> -----Original Message-----
> From: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Sent: Tuesday, November 19, 2024 2:21 PM
> To: 'Sowon Na' <sowon.na@xxxxxxxxxxx>; robh@xxxxxxxxxx; krzk@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx
> Cc: krzk+dt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; 'Krzysztof
> Kozlowski' <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: RE: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS PHY
> bindings
>
>
>
> > -----Original Message-----
> > From: Sowon Na <sowon.na@xxxxxxxxxxx>
> > Sent: Monday, November 18, 2024 7:40 AM
> > To: robh@xxxxxxxxxx; krzk@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> > vkoul@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; kishon@xxxxxxxxxx
> > Cc: krzk+dt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > devicetree@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
> > sowon.na@xxxxxxxxxxx; Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx>
> > Subject: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS PHY
> > bindings
> >
> > Add samsung,exynosautov920-ufs-phy compatible for ExynosAuto v920 SoC.
> >
> > Signed-off-by: Sowon Na <sowon.na@xxxxxxxxxxx>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > ---
> I am not sure how we can help you, you are keep missing to collect all the
> tags
> https://lkml.org/lkml/2024/11/7/617
>
Really sorry for missing tags. I append it immediately, and will not miss anymore.
Your review helps me a lot and makes my patch better. I applied all your reviews to my patches.
Thank you a lot once again for your help.
> > Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> > b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> > index f402e31bf58d..d70ffeb6e824 100644
> > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> > @@ -18,6 +18,7 @@ properties:
> > - google,gs101-ufs-phy
> > - samsung,exynos7-ufs-phy
> > - samsung,exynosautov9-ufs-phy
> > + - samsung,exynosautov920-ufs-phy
> > - tesla,fsd-ufs-phy
> >
> > reg:
> > --
> > 2.45.2
>