Re: [PATCH v2] scsi: ufs: core: Add ufshcd_send_bsg_uic_cmd() for UFS BSG

[Peter Wang (王信友)]

On Tue, 2024-11-19 at 16:52 +0800, Ziqi Chen wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Hi Peter,
> 
> Thank you for your comment. We also recognize that the H8 Enter/Exit
> has
> the same issue. In fact, we have tried to add the H8 command before.
> Unfortunately, the situation with Hibern8 is complex, there are a lot
> of
> status checks, and some vendors have their own sequence that is
> implemented in their vendor driver by Vops. Simply including the H8
> command here would cause other issues since the vendor sequence for
> H8
> enter/exit is required. If we add the full sequence here, the code
> will
> be bloated. We haven’t come up with a good solution for the Hibern8
> situation yet. However, whether we include the H8 command or not, the
> above issue is present as well (directly call ufshcd_send_uic_cmd()
> via
> BSG framework).
> Right now, we have tested the PA_PWRMODE case and confirmed that it
> works, so we want to quickly resolve the PA_PWRMODE issue to unblock
> our
> customers’ urgent cases first. As for the Hibern8 situation, we have
> plan to fix it but we want to fix it afterward, in a separated
> change.
> If you have any good suggestions, we can discuss separately.
> 
> BRs,
> Ziqi
> 

Hi Ziqi,

I can understand.

Thanks.
Peter

Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>