Re: [PATCH md-6.13 4/5] md/raid5: implement pers->bitmap_sector()

From: Yu Kuai
Date: Tue Nov 19 2024 - 05:58:54 EST


Hi,

在 2024/11/19 17:49, Jack Wang 写道:
Hi Kuai,

Thanks for the patchset, as you mentioned both both hung problem regarding raid5
bitmap, just want to get confirmation, will this patchset fix the hung or just a
performance improvement/code cleanup?

I'm hoping both. :)

After review, I'll CC related folks and see if they can comfirm this
will fix the hang problem.


In patch4, as you removed the set/clear bit STRIPE_BITMAP_PENDING, I think you
should also remove the test_bit line in stripe_can_batch, also the definition
enum in raif5.h and the few lines in comments in __add_stripe_bio, same for the
line in break_stripe_batch_list.

Yes, and I assume you mean patch 5.

Thanks,
Kuai



Regards!
Jinpu Wang @ IONOS


.