Re: [PATCH v2 3/4] iio: adc: ad4000: Use device specific timing for SPI transfers

[Marcelo Schmitt]

On 11/18, David Lechner wrote:
> On 11/18/24 12:53 PM, Marcelo Schmitt wrote:
> > The SPI transfers for AD4020, AD4021, and AD4022 have slightly different
> > timing specifications. Use device specific timing constraints to set SPI
> > transfer parameters. While tweaking time constraints, remove time related
> > defines including unused AD4000_TQUIET1_NS.
> > 
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> > ---
> 
> ...
> 
> > +/*
> > + * Same timing specifications for all of AD4000, AD4001, ..., AD4008, AD4010,
> > + * ADAQ4001, and ADAQ4003.
> > + */
> > +static const struct ad4000_time_spec ad4000_t_spec = AD4000_TSPEC(320, 60);
> > +
> > +/* AD4020, AD4021, AD4022 */
> > +static const struct ad4000_time_spec ad4020_t_spec = AD4000_TSPEC(350, 60);
> 
> I actually liked the way you did it in v1 better. This makes it harder to
> see which number is which.
> 
May I add your reviewed-by tag if I change it back to v1 time_spec? :)