Re: [PATCH v1] i2c-mlxbf: Add repeated start condition support

From: Andi Shyti
Date: Tue Nov 19 2024 - 08:45:59 EST


Hi Chris,

On Mon, Nov 18, 2024 at 07:28:33PM +0000, Chris Babroski wrote:
> Add support for SMBus repeated start conditions to the Mellanox I2C
> driver. This support is specifically enabled for the
> I2C_FUNC_SMBUS_WRITE_I2C_BLOCK implementation which is required for
> communication with various I2C devices on Bluefield 3.
>
> The I2C bus timing configuration values have also been updated based on
> latest HW testing results and found to be necessary to support repeated
> start transactions.
>
> Signed-off-by: Chris Babroski <cbabroski@xxxxxxxxxx>
> Reviewed-by: Asmaa Mnebhi <asmaa@xxxxxxxxxx>
> Reviewed-by: Khalil Blaiech <kblaiech@xxxxxxxxxx>

Where did these reviews take place? How is it possible that this
patch, at its v1, already has two reviews?

Please ensure everything happens openly on the mailing list. I
will need to ask Asmaa and Khalil to restate their Reviewed-by
tags here, as they carry very little weight when included by
default in a v1 patch.

Thanks,
Andi