Re: [PATCH] get_task_exe_file: check PF_KTHREAD locklessly
From: Oleg Nesterov
Date: Tue Nov 19 2024 - 10:10:55 EST
On 11/19, Mateusz Guzik wrote:
>
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1500,12 +1500,13 @@ struct file *get_task_exe_file(struct task_struct *task)
> struct file *exe_file = NULL;
> struct mm_struct *mm;
>
> + if (task->flags & PF_KTHREAD)
> + return NULL;
> +
> task_lock(task);
> mm = task->mm;
> - if (mm) {
> - if (!(task->flags & PF_KTHREAD))
> - exe_file = get_mm_exe_file(mm);
> - }
> + if (mm)
> + exe_file = get_mm_exe_file(mm);
> task_unlock(task);
> return exe_file;
Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>