Re: [PATCH v6 07/15] digest_cache: Allow registration of digest list parsers

From: Randy Dunlap
Date: Tue Nov 19 2024 - 11:53:25 EST


Hi--

On 11/19/24 2:49 AM, Roberto Sassu wrote:
> +/**
> + * struct parser - Structure to store a function pointer to parse digest list
> + * @list: Linked list
> + * @owner: Kernel module owning the parser
> + * @name: Parser name (must match the format in the digest list file name)
> + * @func: Function pointer for parsing
> + *
> + * This structure stores a function pointer to parse a digest list.
> + */
> +struct parser {
> + struct list_head list;
> + struct module *owner;
> + const char name[NAME_MAX + 1];
> + parser_func func;
> +};

I would make the struct name not so generic -- maybe digest_parser ...

thanks.
--
~Randy