Re: [PATCH v9 1/9] x86/resctrl: Introduce resctrl_file_fflags_init() to initialize fflags

From: Reinette Chatre
Date: Tue Nov 19 2024 - 19:38:33 EST


Hi Tony,

On 11/13/24 4:17 PM, Tony Luck wrote:
> From: Babu Moger <babu.moger@xxxxxxx>
>
> thread_throttle_mode_init() and mbm_config_rftype_init() both initialize
> fflags for resctrl files.
>
> Adding new files will involve adding another function to initialize
> the fflags. This can be simplified by adding a new function
> resctrl_file_fflags_init() and passing the file name and flags
> to be initialized.
>
> Consolidate fflags initialization into resctrl_file_fflags_init() and
> remove thread_throttle_mode_init() and mbm_config_rftype_init().
>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>

Please place "Signed-off-by" tag before "Reviewed-by" tag. For reference,
"Ordering of commit tags" in Documentation/process/maintainer-tip.rst

Reinette