Re: [PATCH 11/15] ARM: dts: microchip: add sama7d65 SoC DT

[Krzysztof Kozlowski]

On Tue, Nov 19, 2024 at 09:40:17AM -0700, Ryan.Wanner@xxxxxxxxxxxxx wrote:
> From: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
> 
> Add Device Tree for sama7d65 SoC.
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
> Co-developed-by: Romain Sioen <romain.sioen@xxxxxxxxxxxxx>
> Signed-off-by: Romain Sioen <romain.sioen@xxxxxxxxxxxxx>
> Co-developed-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx>
> Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>

Totally confusing SoB chain. Please read carefully submitting patches.

...

> +	clocks {
> +		slow_xtal: clock-slowxtal {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +		};
> +
> +		main_xtal: clock-mainxtal {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +		};
> +	};
> +
> +	vddout25: fixed-regulator-vddout25 {

s/fixed-//

> +		compatible = "regulator-fixed";
> +
> +		regulator-name = "VDDOUT25";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-boot-on;
> +		status = "disabled";
> +	};
> +
> +	soc {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		pioA: pinctrl@e0014000 {

labels are lowercase.

Best regards,
Krzysztof