Re: [PATCH] sched_ext: Documentation: Fix typo in sched-ext.rst

From: Andrea Righi
Date: Wed Nov 20 2024 - 04:36:41 EST


Hi Zhu,

On Sun, Nov 17, 2024 at 06:48:18PM -0800, Zhu Jun wrote:
> The word 'tranfers' is wrong, so fix it.
>
> Signed-off-by: Zhu Jun <zhujun2@xxxxxxxxxxxxxxxxxxxx>
> ---
> Documentation/scheduler/sched-ext.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/scheduler/sched-ext.rst b/Documentation/scheduler/sched-ext.rst
> index 7b59bbd2e564..aff1304d2637 100644
> --- a/Documentation/scheduler/sched-ext.rst
> +++ b/Documentation/scheduler/sched-ext.rst
> @@ -265,7 +265,7 @@ The following briefly shows how a waking task is scheduled and executed.
> rather than performing them immediately. There can be up to
> ``ops.dispatch_max_batch`` pending tasks.
>
> - * ``scx_bpf_consume()`` tranfers a task from the specified non-local DSQ
> + * ``scx_bpf_consume()`` transfer a task from the specified non-local DSQ

Actually it should be "transfers".

However, this will be fixed by 5209c03c8ed2 ("sched_ext: Rename
scx_bpf_consume() to scx_bpf_dsq_move_to_local()") that just renames
"transfers" into "moves".

> to the dispatching DSQ. This function cannot be called with any BPF
> locks held. ``scx_bpf_consume()`` flushes the pending dispatched tasks
> before trying to consume the specified DSQ.
> --
> 2.17.1
>
>
>

Thanks,
-Andrea