Re: [PATCH v4 2/2] arm64: dts: qcom: sa8775p-ride: Enable Display Port

[Dmitry Baryshkov]

On Wed, Nov 20, 2024 at 05:23:24PM +0530, Soutrik Mukhopadhyay wrote:
> 
> On 11/20/2024 5:13 PM, Dmitry Baryshkov wrote:
> > On Wed, Nov 20, 2024 at 05:05:50PM +0530, Soutrik Mukhopadhyay wrote:
> > > > On 11/20/2024 4:42 PM, Dmitry Baryshkov wrote:
> > > > On Wed, Nov 20, 2024 at 04:29:54PM +0530, Soutrik Mukhopadhyay wrote:
> > > > > Enable DPTX0 and DPTX1 along with their corresponding PHYs for
> > > > > sa8775p-ride platform.
> > > > > > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@xxxxxxxxxxx>
> > > > > ---
> > > > >  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++
> > > > >  1 file changed, 80 insertions(+)
> > > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> > > > b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> > > > > index adb71aeff339..4847e4942386 100644
> > > > > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> > > > > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> > > > > @@ -27,6 +27,30 @@
> > > > >  	chosen {
> > > > >  		stdout-path = "serial0:115200n8";
> > > > >  	};
> > > > > +
> > > > > +	dp0-connector {
> > > > > +		compatible = "dp-connector";
> > > > > +		label = "DP0";
> > > > > > Thundercomm's SA8775p RIDE platform doesn't show such a
> > connector. At
> > > > least not on a device advertised on the web pages.
> > > > > Are you referring to this product in the Thundercomm web page :
> > SA8225P and
> > > SA8775P
> > > Ride SX 4.0 Automotive Development Platform ?
> > 
> > Yes
> > 
> > > For this particular product we
> > > can see
> > > eDP 0/1/2/3 serving as the dp connectors.
> > 
> > Please correct the labels then. And also please mention why eDP2/3 are
> > not included / tested.
> 
> 
> Sure, we will update the labels in the upcoming patchset.
> edp 0/1 corresponds to mdss0_dptx0 and mdss0_dptx1. We have validated only
> these.
> edp 2/3 corresponds to mdss1_dptx0 and mdss1_dptx1, and these are not
> validated,
> as already mentioned during the driver changes for the same.
> Should we mention the same in the commit message for the upcoming patchset ?

Yes, please mention this in the commit message for this patchset.

> > > > > > > > > +		type = "full-size";
> > > > > +
> > > > > +		port {
> > > > > +			dp0_connector_in: endpoint {
> > > > > +				remote-endpoint = <&mdss0_dp0_out>;
> > > > > +			};
> > > > > +		};
> > > > > +	};
> > > > > +
> > > > > +	dp1-connector {
> > > > > +		compatible = "dp-connector";
> > > > > +		label = "DP1";
> > > > > > Same comment here.
> > > > > > > +		type = "full-size";
> > > > > +
> > > > > +		port {
> > > > > +			dp1_connector_in: endpoint {
> > > > > +				remote-endpoint = <&mdss0_dp1_out>;
> > > > > +			};
> > > > > +		};
> > > > > +	};
> > > > >  };
> > > > >  >  &apps_rsc {
> > > >
> > 

-- 
With best wishes
Dmitry