Re: [PATCH] seqlock: annotate spinning as unlikely() in __read_seqcount_begin

[Peter Zijlstra]

On Wed, Nov 20, 2024 at 12:11:45PM +0100, Christian Brauner wrote:
> On Thu, 27 Jul 2023 20:03:55 +0200, Mateusz Guzik wrote:
> > Annotation already used to be there, but got lost in 52ac39e5db5148f7
> > ("seqlock: seqcount_t: Implement all read APIs as statement expressions").
> > Does not look like it was intentional.
> > 
> > Without it gcc 12 decides to compile the following in path_init:
> >         nd->m_seq = __read_seqcount_begin(&mount_lock.seqcount);
> >         nd->r_seq = __read_seqcount_begin(&rename_lock.seqcount);
> > 
> > [...]
> 
> Applied to the vfs-6.14.misc branch of the vfs/vfs.git tree.
> Patches in the vfs-6.14.misc branch should appear in linux-next soon.
> 
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
> 
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>