Re: [RESEND PATCH] net: microchip: vcap: Add typegroup table terminators in kunit tests
From: Guenter Roeck
Date: Wed Nov 20 2024 - 10:10:49 EST
On Wed, Nov 20, 2024 at 10:52:02AM +0000, Daniel Machon wrote:
> Hi Guenter,
>
> > Comments in the code state that "A typegroup table ends with an all-zero
> > terminator". Add the missing terminators.
> >
> > Some of the typegroups did have a terminator of ".offset = 0, .width = 0,
> > .value = 0,". Replace those terminators with "{ }" (no trailing ',') for
> > consistency and to excplicitly state "this is a terminator".
> >
> > Fixes: 67d637516fa9 ("net: microchip: sparx5: Adding KUNIT test for the VCAP API")
> > Cc: Steen Hegelund <steen.hegelund@xxxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > resend: forgot to copy netdev@.
>
> You are missing the target tree in the subject - in this case it should be
> 'net'
Sorry, I seem to be missing something. The subject starts with
"net: microchip: vcap: Add ...". How should it look like instead ?
Thanks,
Guenter