Re: [RFCv1 0/6] Page Detective

From: Pasha Tatashin
Date: Wed Nov 20 2024 - 12:47:58 EST


> > /* Use static buffer, for the caller is holding oom_lock. */
> > static char buf[PAGE_SIZE];
> > ....
> > seq_buf_init(&s, buf, sizeof(buf));
> > memory_stat_format(memcg, &s);
> > seq_buf_do_printk(&s, KERN_INFO);
> > }
> >
> > This is a callosal stack allocation, given that our fleet only has 8K
> > stacks. :-)
>
> That's a static allocation though :)

Ah right, did not notice it was static (and ignored the comment)

Pasha