Re: [PATCH v4] usb: dwc3: remove unused sg struct member
From: Thinh Nguyen
Date: Wed Nov 20 2024 - 18:49:17 EST
On Wed, Nov 20, 2024, Luis Felipe Hernandez wrote:
> The sg (scatter-gather list pointer) member of the dwc3_request struct
> is no longer used and should be removed. This patch eliminates the unused
> member, cleaning up the struct.
>
> This change improves code clarity and avoids maintaining unnecessary
> members in the structure.
>
> Reviewed-by: Ricardo B. Marliere <rbm@xxxxxxxx>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Closes: https://urldefense.com/v3/__https://lore.kernel.org/all/20241118194006.77c7b126@xxxxxxxxxxxxxxxx/__;!!A4F2R9G_pg!eBhj52Qaf_wGZmK74SLHSw2uJlwWgyHE70QFVO3aX8FgZPyykzdriHqQGG88l9Gabsn_lXOPzzuUTERGxVOb0dgDJjEAMf4$
> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@xxxxxxxxx>
> ---
> v2: remove unused sg struct member as per review[1]
> v3:
> - Add reported-by tag as per review [2]
> - Carry over reviewed-by tag from v2 [3]
> - Update commit subject to reflect maintainers
> - Update commit message to reflect actual change gathered from
> Thinh Nguyen's feedback
>
> [1] https://urldefense.com/v3/__https://lore.kernel.org/all/20241119020807.cn7ugxnhbkqwrr2b@xxxxxxxxxxxx/__;!!A4F2R9G_pg!eBhj52Qaf_wGZmK74SLHSw2uJlwWgyHE70QFVO3aX8FgZPyykzdriHqQGG88l9Gabsn_lXOPzzuUTERGxVOb0dgD-sCH4TU$
> [2] https://urldefense.com/v3/__https://lore.kernel.org/all/2024111922-pantyhose-panorama-6f16@gregkh/__;!!A4F2R9G_pg!eBhj52Qaf_wGZmK74SLHSw2uJlwWgyHE70QFVO3aX8FgZPyykzdriHqQGG88l9Gabsn_lXOPzzuUTERGxVOb0dgDxMWDM-0$
> [3] https://urldefense.com/v3/__https://lore.kernel.org/all/5l65sdskdzbehxamff5ax4ptiqhaxh7ewi4umtpp6ynen45nj6@nebuxjg4c4rx/__;!!A4F2R9G_pg!eBhj52Qaf_wGZmK74SLHSw2uJlwWgyHE70QFVO3aX8FgZPyykzdriHqQGG88l9Gabsn_lXOPzzuUTERGxVOb0dgDs-MF_6M$
> v4:
> - Remove out of context paragraph from commit message as per
> Thinh Nguyen's[1]
> - Fix Reported-by, correctly attribute report to Stephen Rothwell
>
> [1] https://urldefense.com/v3/__https://lore.kernel.org/all/20241119221907.tyt4luboduaymukl@xxxxxxxxxxxx/__;!!A4F2R9G_pg!eBhj52Qaf_wGZmK74SLHSw2uJlwWgyHE70QFVO3aX8FgZPyykzdriHqQGG88l9Gabsn_lXOPzzuUTERGxVOb0dgDudqBTNQ$
> ---
> drivers/usb/dwc3/core.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index ee73789326bc..3be069c4520e 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -956,7 +956,6 @@ struct dwc3_request {
> struct usb_request request;
> struct list_head list;
> struct dwc3_ep *dep;
> - struct scatterlist *sg;
> struct scatterlist *start_sg;
>
> unsigned int num_pending_sgs;
> --
> 2.47.0
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
Thanks,
Thinh